-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add diagrams for the import and scanning component #154
base: next
Are you sure you want to change the base?
docs: add diagrams for the import and scanning component #154
Conversation
Signed-off-by: Nam Hoang <[email protected]>
participant MA as Mock App | ||
participant V as VCKit | ||
|
||
U->>MA: Import file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@namhoang1604, what are the permitted data structures of the file being imported? What are the allowed file extensions? What are the permitted credential types?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ashleythedeveloper, the data structure is defined here, they can be VC or JSON. There is a component render-check-list added examples for cases can happen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ashleythedeveloper, I updated it for more details.
participant V as VCKit | ||
|
||
U->>MA: Scan QRCode | ||
MA->>MA: Fetch data from QRCode URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@namhoang1604, what are the permitted data structures of the QRpayload? Can we also use a Data Matrix? What are the permitted data structures of the file being fetched? What are the allowed file extensions? What are the permitted credential types? What happens if the contents of the credential being fetched are encrypted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The data structure is defined here, it allows VC or JSON. The current implementation is not handling the encrypted data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ashleythedeveloper, I updated it for more details.
What type of PR is this? (check all applicable)
Description
This PR updates the diagram for the import and scanning component.
Related Tickets & Documents
https://github.com/gs-gs/fa-ag-trace/issues/667
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?